Typo?

colin-adams — Thu, 19 Apr 2007 22:49:43 -0700

Hello Jasmine,

Firstly, it would be easier to read your code if you included it within eiffel XML tags (see MediaWiki syntax when posting).

I can see a few problems with your code.

Firstly, it should be io.last_string (you omitted the io.). Secondly, I think you need to call io.last_string.twin, which will copy the last string. The problem is that io.last_string is re-used, so all the entries in your array point to the same object.

Thirdly, since you know the size of the array, it would be better to size it correctly, and use put, not force.

Also, avoid loops when you can (not always possible). Agents are better.

So something like this:

feature -- Test

test is

  -- Test reading multiple words from standard input

local

 my_array: ARRAY [STRING]

 i: INTEGER

do

 create my_array.make (1, 10)

 from

  i := 1

 until

  i > 10

 loop

  io.read_word

  my_array.put (io.last_string.twin, i)

  i := i + 1

 end

 my_array.do_all (agent print_line)

end

print_line (a_string: STRING) is

  -- Print `a_string' on standard output followed by a new line.

require

 a_string_not_void: a_string /= Void

do

 print (a_string + "%N")

end

Colin Adams

eiffelroom - io - Comments

Typo?